Add condition with sum and count for Prometheus summaries #3059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khanhntd
force-pushed
the
update_summaries
branch
from
1079cdc
to
6b05705
Compare
khanhntd
force-pushed
the
update_summaries
branch
from
eae7253
to
5debba7
Compare
jack-berg
approved these changes
Jan 4, 2023
dashpole
reviewed
Jan 5, 2023
khanhntd
force-pushed
the
update_summaries
branch
from
71125db
to
01c7b5d
Compare
MrAlias
approved these changes
Jan 5, 2023
|
@open-telemetry/specs-metrics-approvers please review. |
dashpole
approved these changes
Jan 9, 2023
khanhntd
force-pushed
the
update_summaries
branch
from
441c6b0
to
3cd0591
Compare
jmacd
approved these changes
Jan 9, 2023
reyang
reviewed
Jan 10, 2023
reyang
approved these changes
Jan 10, 2023
khanhntd
changed the title
khanhntd
force-pushed
the
update_summaries
branch
2 times, most recently
from
847bf74
to
c9e01fc
Compare
Aneurysm9
approved these changes
Jan 10, 2023
khanhntd
force-pushed
the
update_summaries
branch
from
c9e01fc
to
9ceb21a
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
khanhntd
force-pushed
the
update_summaries
branch
from
eec6cd5
to
7c2e604
Compare
|
cc @tigrannajaryan for re-run the workflow and merging |
dashpole
approved these changes
Jan 19, 2023
|
@open-telemetry/specs-metrics-approvers this has required number of approvals. I will merge in 2 business days if I don't see objections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update condition with sum and count for prometheus summaries since summaries will be dropped if count is not exist and if sum is not exist, then it should not be set. It is the same behavior with histogram so there are not changes in the wording.