Add db.values #3091
Add db.values #3091
Conversation
| type: string | ||
| requirement_level: | ||
| conditionally_required: > | ||
| If applicable and not explicitly disabled via instrumentation configuration. |
There was a problem hiding this comment.
Does it make sense to indicate here how this can be turned off? Is it something "speced" or it differs from instrumentation to instrumentation? And I guess the "data sensitivity" concern with these values are protected somehow by this opt-in configuration?
| * [MySQL](#mysql) | ||
| * [Redis](#redis) | ||
| * [MongoDB](#mongodb) | ||
| - [Semantic conventions for database client calls](#semantic-conventions-for-database-client-calls) |
There was a problem hiding this comment.
Did you run the markdown generator tool or change this manually? I think the build is failing because of it. The top-level page title is not in the table of contents I think, so the diff does not match.
There was a problem hiding this comment.
Sorry, I was sure I closed this PR.
I opened another one yesterday in which I changed only the database.yaml file, can you please refer to it?
#3092.
I thought I only need to change the yaml file, but according to your comment, I'll read the CONTRIBUTING.md file and act accordingly.
There was a problem hiding this comment.
I'm a bit confused 😅 which PR is the "real" one? This or #3092? Can you close the one that's obsolete now?
Fixes open-telemetry/semantic-conventions#716
Changes
Add
db.valuesto DB span. it contains the values that come with the query (like in mongo/mysql and more)