Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(db.values): add db.bind.values to yaml #3092

Closed
wants to merge 22 commits into from
Closed
Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
181cae4
feat(db.values): add db.values to yaml
haddasbronfman Jan 10, 2023
58b4198
feat(db.values): after smoe fixes + run make table-generation
haddasbronfman Jan 12, 2023
bd7c96c
Merge branch 'main' into db-values
haddasbronfman Jan 12, 2023
58384c4
Merge branch 'main' into db-values
haddasbronfman Jan 15, 2023
a52d1de
feat(db.values): add CHANGELOG. requirement level=optional, name=bind…
haddasbronfman Jan 19, 2023
194f3c0
feat(db.values): fix confloct in CHANGELOG
haddasbronfman Jan 19, 2023
bcb0ed9
Merge branch 'db-values' of https://github.com/haddasbronfman/opentel…
haddasbronfman Jan 19, 2023
ab080ab
feat(db.values): edit brief
haddasbronfman Jan 19, 2023
d66eeae
Merge branch 'main' into db-values
haddasbronfman Jan 26, 2023
efe9277
Merge branch 'main' into db-values
haddasbronfman Jan 29, 2023
2ee03da
Merge branch 'main' into db-values
haddasbronfman Feb 1, 2023
31cb6c4
Update CHANGELOG.md
haddasbronfman Feb 1, 2023
cbb66e7
Merge branch 'main' into db-values
haddasbronfman Feb 5, 2023
c1d20c7
fix(docker): remove the call to /inventory as it's not working, until…
haddasbronfman Feb 6, 2023
87c19c4
Merge branch 'db-values' of https://github.com/haddasbronfman/opentel…
haddasbronfman Feb 6, 2023
7342a6f
Merge branch 'main' into db-values
haddasbronfman Feb 6, 2023
e4410e5
Merge branch 'main' into db-values
haddasbronfman Feb 7, 2023
3e719aa
Merge branch 'main' into db-values
haddasbronfman Feb 9, 2023
90a2826
Merge branch 'main' into db-values
haddasbronfman Feb 12, 2023
7c3fb4b
Merge branch 'main' into db-values
haddasbronfman Feb 19, 2023
c55bd57
Merge branch 'main' into db-values
haddasbronfman Feb 27, 2023
194852e
Merge branch 'main' into db-values
haddasbronfman Feb 27, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ release.
([#3044](https://github.com/open-telemetry/opentelemetry-specification/pull/3044))
- Add `code.lineno` source code attribute
([#3029](https://github.com/open-telemetry/opentelemetry-specification/pull/3029))
- Add `db.values` attribute to database specification. [#3092](https://github.com/open-telemetry/opentelemetry-specification/pull/3092)
haddasbronfman marked this conversation as resolved.
Show resolved Hide resolved
- Add ClickHouse to db.system semantic conventions
([#3011](https://github.com/open-telemetry/opentelemetry-specification/pull/3011))
- Refactor messaging attributes and per-message attributes in batching scenarios.
Expand Down
7 changes: 7 additions & 0 deletions semantic_conventions/trace/database.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,13 @@ groups:
The database statement being executed.
note: The value may be sanitized to exclude sensitive information.
examples: ['SELECT * FROM wuser_table', 'SET mykey "WuValue"']
- id: bind_values
tag: call-level
type: string[]
haddasbronfman marked this conversation as resolved.
Show resolved Hide resolved
requirement_level: optional
brief: >
An array with the values of the SQL statement bind parameters.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in this PR, the attribute can also be used for non-SQL statements. Do you think we should update the text accordingly?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
An array with the values of the SQL statement bind parameters.
An array with the values of the db statement bind parameters.

or:

Suggested change
An array with the values of the SQL statement bind parameters.
An array with the values of the db operation bind parameters.

?

examples: ["David", "1234"]
- id: operation
tag: call-level
type: string
Expand Down
1 change: 1 addition & 0 deletions specification/trace/semantic_conventions/database.md
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ Usually only one `db.name` will be used per connection though.
|---|---|---|---|---|
| `db.name` | string | This attribute is used to report the name of the database being accessed. For commands that switch the database, this should be set to the target database (even if the command fails). [1] | `customers`; `main` | Conditionally Required: If applicable. |
| `db.statement` | string | The database statement being executed. [2] | `SELECT * FROM wuser_table`; `SET mykey "WuValue"` | Conditionally Required: [3] |
| `db.bind_values` | string[] | An array with the values of the SQL statement bind parameters. | `[David, 1234]` | Optional |
| `db.operation` | string | The name of the operation being executed, e.g. the [MongoDB command name](https://docs.mongodb.com/manual/reference/command/#database-operations) such as `findAndModify`, or the SQL keyword. [4] | `findAndModify`; `HMSET`; `SELECT` | Conditionally Required: If `db.statement` is not applicable. |

**[1]:** In some SQL databases, the database name to be used is called "schema name". In case there are multiple layers that could be considered for database name (e.g. Oracle instance name and schema name), the database name to be used is the more specific layer (e.g. Oracle schema name).
Expand Down