Http route should contain application root #3164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
approved these changes
Feb 1, 2023
reyang
approved these changes
Feb 1, 2023
lmolkova
approved these changes
Feb 1, 2023
trask
added
area:semantic-conventions
arminru
approved these changes
Feb 3, 2023
jsuereth
approved these changes
Feb 3, 2023
trask
force-pushed
the
http-route-app-root
branch
from
200ae2e
to
ffd6c4f
Compare
trask
force-pushed
the
http-route-app-root
branch
from
829e502
to
929f240
Compare
trask
force-pushed
the
http-route-app-root
branch
from
929f240
to
86e8815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3156
Changes
Makes it clear that
http.routeSHOULD contain the "application root" if there is one.