Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric requirement levels #3237

Merged
merged 11 commits into from
Feb 23, 2023
Merged

Conversation

trask
Copy link
Member

@trask trask commented Feb 21, 2023

Part of #3176 (remaining part is adding the metric requirement level to the yaml files and generating markdown)

Changes

Adds metric requirement levels "Required", "Recommended", "Opt-In" (see #3228), reflecting the similar requirement levels for attributes.

"Conditionally Required" can be added now or when the need arises.

@trask trask requested review from a team as code owners February 21, 2023 00:18
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'd love to see this come in stable, understand pulling in experimental first given the opt-in discussion.

@arminru arminru added area:semantic-conventions Related to semantic conventions spec:metrics Related to the specification/metrics directory labels Feb 21, 2023
specification/metrics/metric-requirement-level.md Outdated Show resolved Hide resolved
specification/metrics/metric-requirement-level.md Outdated Show resolved Hide resolved
specification/metrics/metric-requirement-level.md Outdated Show resolved Hide resolved
trask and others added 4 commits February 21, 2023 16:38
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
@trask trask requested a review from a team as a code owner February 22, 2023 00:45
@reyang reyang merged commit 0b41c63 into open-telemetry:main Feb 23, 2023
jsuereth pushed a commit to jsuereth/opentelemetry-specification that referenced this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants