Show relationship between http target and route in example usage #3292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
reviewed
Mar 6, 2023
There was a problem hiding this comment.
thx!
can you make this change also to
and then the build should pass (the markdown tables are autogenerated, see https://github.com/open-telemetry/opentelemetry-specification/blob/main/semantic_conventions/README.md#generating-markdown)
trask
added
area:semantic-conventions
yurishkuro
approved these changes
Mar 6, 2023
trask
approved these changes
Mar 6, 2023
scheler
reviewed
Mar 7, 2023
mateuszrzeszutek
approved these changes
Mar 7, 2023
lmolkova
pushed a commit
to lmolkova/opentelemetry-specification
that referenced
this pull request
Mar 8, 2023
…n-telemetry#3292) Clarify relationship between `http.target` and `http.route` by using the same pattern in the example usage. Having different patterns for the attribute values distorts the relationship between the two attributes. A similar pattern is seen in the docs for [`aws-lambda.md`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/instrumentation/aws-lambda.md#api-gateway-request-proxy-lambda-tracing-passive), where `http.target` is `/pets/10` and `http.route` is `/pets/{petId}`. It's a minor adjustment but should help provide clarity for new users. --------- Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Clarify relationship between
http.targetandhttp.routeby using the same pattern in the example usage. Having different patterns for the attribute values distorts the relationship between the two attributes.A similar pattern is seen in the docs for
aws-lambda.md, wherehttp.targetis/pets/10andhttp.routeis/pets/{petId}. It's a minor adjustment but should help provide clarity for new users.