Fix grammatical number of metric semconv units #3298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
area:semantic-conventions
jmacd
approved these changes
Mar 8, 2023
jack-berg
approved these changes
Mar 8, 2023
trask
approved these changes
Mar 8, 2023
reyang
approved these changes
Mar 8, 2023
lmolkova
pushed a commit
to lmolkova/opentelemetry-specification
that referenced
this pull request
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3295
Changes
Currently the metric semantic conventions are defined with non-units of improper grammatical number. This update changes existing plurals into singulars (I didn't find any instances of singulars that needed to be switched to plurals with a quantity).