Clarify parameters for emtting a log record #3354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-berg
reviewed
Mar 31, 2023
jack-berg
approved these changes
Mar 31, 2023
reyang
approved these changes
Mar 31, 2023
cijothomas
reviewed
Mar 31, 2023
martinkuba
approved these changes
Apr 1, 2023
jack-berg
reviewed
Apr 3, 2023
jack-berg
reviewed
Apr 3, 2023
jack-berg
approved these changes
Apr 3, 2023
MSNev
approved these changes
Apr 5, 2023
tigrannajaryan
approved these changes
Apr 6, 2023
|
@alanwest please fix the build. |
reyang
reviewed
Apr 6, 2023
reyang
reviewed
Apr 6, 2023
reyang
reviewed
Apr 6, 2023
Co-authored-by: Reiley Yang <reyang@microsoft.com>
…elemetry-specification into alanwest/logs-and-context
jack-berg
approved these changes
Apr 6, 2023
tigrannajaryan
approved these changes
Apr 6, 2023
|
Hey @alanwest can you add a changelog entry? |
alanwest
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #3350
Clarifies the parameters for emitting a log record.
Context was particularly confusing. Context is not a property of the
LogRecorddata model. Cleans up section of bridge API spec that seems to suggest that Context is a field ofLogRecord. Also, clarifies that Context can be associated with an emitted LogRecord. We have similar language in the trace API that leaves room for languages to achieve this in an idiomatic way. Seeopentelemetry-specification/specification/trace/api.md
Lines 365 to 370 in d25734a