Mark LogRecord EnvVars stable #3449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanwest
approved these changes
Apr 26, 2023
utpilla
approved these changes
Apr 26, 2023
Merged
2 tasks
|
Hmm, this was an oversight too: https://github.com/open-telemetry/opentelemetry-specification/pull/3449/files#diff-b31589a66a50cd233a213894f3b191e3f42892c34a0ba72d28dc1e0749f43046R128 We'd settled on 1000ms default for exportTimeoutMillis in #3002. |
arminru
added
spec:logs
|
Updated...
|
jack-berg
approved these changes
Apr 27, 2023
alanwest
approved these changes
Apr 27, 2023
tigrannajaryan
approved these changes
Apr 28, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #3376
Changes
Details
#3376 marked most of the logs spec stable but we noticed implementing things in .NET that the EnvVars were still experimental. This felt like an oversight so here's a PR to fix things up.
/cc @alanwest @utpilla @jack-berg @tigrannajaryan