Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify how to handle instrument name conflict #3626

Merged
merged 19 commits into from Aug 9, 2023
Merged

Specify how to handle instrument name conflict #3626

merged 19 commits into from Aug 9, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jul 26, 2023

  • Refactor the "Duplicate instrument registration" section
  • Clarify how to handle when instrument names differ by only their casing:
    1. Return the first-seen instrument name for all conflicting instrument names
    2. Log a warning

Resolves #3539

cc @jack-berg @ocelotl @dyladan

@MrAlias MrAlias requested review from a team as code owners July 26, 2023 19:34
@MrAlias MrAlias mentioned this pull request Jul 26, 2023
Closed
pellared
pellared approved these changes Jul 27, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
MrAlias and others added 2 commits July 27, 2023 07:22
@MrAlias @pellared
Update CHANGELOG.md
190269a 
Co-authored-by: Robert Pająk <pellared@hotmail.com>
@MrAlias
Merge branch 'main' into inst-name-conflict
0a6451a
jack-berg
jack-berg approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@arminru arminru added area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory labels Aug 1, 2023
@jack-berg jack-berg mentioned this pull request Aug 4, 2023
Merged
@MrAlias MrAlias mentioned this pull request Aug 7, 2023
Merged
@carlosalberto
Copy link
Contributor

carlosalberto commented Aug 7, 2023 •
edited

@MrAlias asked in our 1.24.0 release whether this can be included too. Does anybody oppose it? Otherwise, let's merge this PR prior to the August release.

@carlosalberto carlosalberto merged commit 2038b78 into open-telemetry:main Aug 9, 2023
7 checks passed
@MrAlias MrAlias deleted the inst-name-conflict branch August 9, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arminru arminru arminru left review comments

@jsuereth jsuereth jsuereth approved these changes

@dashpole dashpole dashpole approved these changes

@jmacd jmacd jmacd approved these changes

@pellared pellared pellared approved these changes

@reyang reyang reyang approved these changes

@jack-berg jack-berg jack-berg approved these changes

Assignees

@yurishkuro yurishkuro

Labels
area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory
Projects
No open projects
Go: Metric SDK (GA)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to handle case-insensitive instrument name collisions in metric SDK
10 participants
@MrAlias @carlosalberto @jsuereth @dashpole @jmacd @pellared @arminru @reyang @jack-berg @yurishkuro