Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent tracestate reference #3633

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Conversation

PerfectSlayer
Copy link
Contributor

Changes

I just would like to report that all links to W3C tracestate specifications are either:

But specification/overview.md is using:

Do you need me to open an issue first?

@PerfectSlayer PerfectSlayer requested review from a team as code owners August 1, 2023 12:44
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 1, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: PerfectSlayer / name: Bruce Bujon (65a7e2d)
  • ✅ login: reyang / name: Reiley Yang (7d41a4a)

@reyang reyang added the editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. label Aug 1, 2023
@carlosalberto
Copy link
Contributor

It seems https://w3c.github.io/trace-context/#tracestate-field is pointing to the most recent version (a draft), which indeed is probably not what we want. Maybe @dyladan has some insight into the different links?

@dyladan
Copy link
Member

dyladan commented Aug 7, 2023

Indeed you most likely don't want the draft unless you're specifically referencing draft features like the random flag.

@reyang reyang merged commit 19044c0 into open-telemetry:main Aug 7, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants