Clarify that metric advice is non-identifying #3661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
non-identifying-advice
branch
from
2a2338b
to
074b320
Compare
reyang
approved these changes
Aug 15, 2023
trask
approved these changes
Aug 15, 2023
MrAlias
approved these changes
Aug 15, 2023
mateuszrzeszutek
approved these changes
Aug 16, 2023
arminru
approved these changes
Aug 16, 2023
jack-berg
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3622
The language for resolving conflicts matches the language used for naming conflicts.
cc @MrAlias @jack-berg @jmacd