Add "/" to valid characters for instrument names #3684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
force-pushed
the
allow-slash-3422
branch
from
2e0d6cd
to
d994745
Compare
reyang
approved these changes
Sep 8, 2023
cijothomas
reviewed
Sep 8, 2023
cijothomas
approved these changes
Sep 8, 2023
|
"Instrument names conform to the specified syntax." This section from https://github.com/open-telemetry/opentelemetry-specification/blob/main/spec-compliance-matrix.md should be reset or modified with a new entry, to make it easy to tell which languages have implemented this. |
utpilla
approved these changes
Sep 8, 2023
Thanks, I cleared out the row |
This was referenced Sep 12, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3422
Changes
Updated the allowed characters for metric instrument names in the OTel API to permit the
/character. See #3422 for use cases and discussion./characters #3422CHANGELOG.mdfile updated for non-trivial changes