Rename/replace (client|server).socket.(address|port) attributes with network.(peer|local).(address|port).
#3713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
network-attr-update
branch
from
124d981
to
1f2a886
Compare
…network.(peer|local).(address|port).
trask
force-pushed
the
network-attr-update
branch
from
1f2a886
to
5e654f3
Compare
lmolkova
approved these changes
Oct 4, 2023
arminru
approved these changes
Oct 5, 2023
Oberon00
approved these changes
Oct 11, 2023
pyohannes
approved these changes
Oct 18, 2023
carlosalberto
approved these changes
Oct 19, 2023
mateuszrzeszutek
approved these changes
Oct 20, 2023
AlexanderWert
approved these changes
Oct 20, 2023
This was referenced Dec 12, 2023
carlosalberto
pushed a commit
that referenced
this pull request
Jan 9, 2024
Fixes #3793 ## Changes Update OpenTelemetry to Zipkin Transformation to handle attributes from older semantic conventions in a backwards compatible way so that following attributes are (again) handled: - `net.peer.name` - `net.host.name` - `net.sock.peer.addr` & `net.sock.peer.port` - `server.socket.domain` - `server.socket.address` & `server.socket.port` The backwards compatibility of a stable OpenTelemetry to Zipkin Transformation was broken by: - #3402 - #3713
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queuing this PR so I don't forget once open-telemetry/semantic-conventions#342 is (hopefully) merged.open-telemetry/semantic-conventions#342 is merged nowChanges
Rename/replace
(client|server).socket.(address|port)attributes withnetwork.(peer|local).(address|port).