Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add definition for standard output logging exporter #3741

Conversation

codeboten
Copy link
Contributor

Changes

I couldn't find the definition for a standard output exporter for the logging signal, so I'm submitting one. This is mostly a copy of the definition already present for the metrics exporter. It doesn't specify a format for the output itself.

Similar to #3740

This is the mostly a copy of the metrics standard output exporter definition but for the logging signal.

Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten requested review from a team as code owners October 26, 2023 16:42
codeboten pushed a commit to codeboten/opentelemetry-specification that referenced this pull request Oct 26, 2023
This PR is a follow up to open-telemetry#3740 and open-telemetry#3741. As some languages (the ones I looked at were: python, js, ruby) already support the `console` type of exporter, I thought it would be good if the spec confirmed it.

Signed-off-by: Alex Boten <aboten@lightstep.com>
@jack-berg
Copy link
Member

I'll keep my comments on #3740 and assume that whatever we do over for the span version of the exporter will be mirrored for logs.

Alex Boten and others added 3 commits November 14, 2023 09:50
@codeboten
Copy link
Contributor Author

Don't think the deadlink is caused by this change

 ERROR: 1 dead links found in ./CONTRIBUTING.md !
  [✖] https://nodejs.org/ → Status: 525

@carlosalberto carlosalberto merged commit f1bdc37 into open-telemetry:main Nov 20, 2023
7 checks passed
@codeboten codeboten deleted the codeboten/add-stdout-exporters-logs branch November 20, 2023 16:04
codeboten pushed a commit to codeboten/opentelemetry-specification that referenced this pull request Nov 21, 2023
This PR is a follow up to open-telemetry#3740 and open-telemetry#3741. As some languages (the ones I looked at were: python, js, ruby) already support the `console` type of exporter, I thought it would be good if the spec confirmed it.

Signed-off-by: Alex Boten <aboten@lightstep.com>
carlosalberto pushed a commit that referenced this pull request Nov 27, 2023
## Changes

This PR is a follow up to
#3740
and
#3741.
As some languages (the ones I looked at were: python, js, ruby) already
support the `console` type of exporter, I thought it would be good if
the spec confirmed it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants