add optional configuration for prometheus exporter #3777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The suffix for types and units can be optionally disabled in Prometheus exporters. This PR captures these configuration options to allow them to then be captured by the OpenTelemetry Configuration as well. Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
jack-berg
reviewed
Nov 28, 2023
dashpole
reviewed
Nov 28, 2023
Co-authored-by: David Ashpole <dashpole@google.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
jack-berg
approved these changes
Dec 3, 2023
dashpole
approved these changes
Dec 4, 2023
reyang
reviewed
Dec 4, 2023
MSNev
approved these changes
Dec 12, 2023
jmacd
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
I'm happy with WithUnits() or WithoutUnits() either way.
I've stated my "either way" case as:
- the existing environment variable spec encourages default=false configurations
- there are many collector configuration fields today which are default=true (e.g., queue_sender::enabled)
carlosalberto
approved these changes
Dec 12, 2023
reyang
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The suffix for types and units can be optionally disabled in Prometheus exporters. This PR captures these configuration options to allow them to then be captured by the OpenTelemetry Configuration as well.
CHANGELOG.mdfile updated for non-trivial changesspec-compliance-matrix.mdupdated if necessary