Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that attribute keys are case-sensitive #3784

Merged
merged 7 commits into from Dec 19, 2023
Merged

Clarify that attribute keys are case-sensitive #3784

merged 7 commits into from Dec 19, 2023

Conversation

arminru
Copy link
Member

@arminru arminru commented Dec 6, 2023

Fixes #3782.

@arminru arminru requested review from a team as code owners December 6, 2023 17:41
@arminru arminru mentioned this pull request Dec 6, 2023
Closed
MrAlias
MrAlias reviewed Dec 6, 2023
View reviewed changes
Copy link
Contributor

@MrAlias MrAlias left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you verified with all the stable releases that this will not conflict with their implementations?

specification/common/README.md Outdated Show resolved Hide resolved
specification/common/README.md Show resolved Hide resolved
tigrannajaryan
tigrannajaryan approved these changes Dec 6, 2023
View reviewed changes
specification/common/README.md Outdated Show resolved Hide resolved
@carlosalberto
Copy link
Contributor

@MrAlias @reyang Any blocking feedback that still needs to be addressed?

@reyang
Copy link
Member

reyang commented Dec 13, 2023

@MrAlias @reyang Any blocking feedback that still needs to be addressed?

Not from me 👍, thanks!

@carlosalberto
Copy link
Contributor

Merging as there don't seem to be any blockers. Feel free to open an issue so we follow up any potential refinement @MrAlias, thanks!

@reyang reyang merged commit 5249c34 into open-telemetry:main Dec 19, 2023
7 checks passed
@arminru arminru deleted the attributes-case-sensitive branch December 20, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@reyang reyang reyang left review comments

@carlosalberto carlosalberto carlosalberto approved these changes

@AlexanderWert AlexanderWert AlexanderWert approved these changes

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@MrAlias MrAlias MrAlias approved these changes

@pyohannes pyohannes pyohannes approved these changes

@jack-berg jack-berg jack-berg approved these changes

Assignees

@carlosalberto carlosalberto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Span attribute keys have unspecified case sensitivity
9 participants
@arminru @carlosalberto @reyang @AlexanderWert @yurishkuro @tigrannajaryan @MrAlias @pyohannes @jack-berg