Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify metric view measurement processing #3842

Merged
merged 2 commits into from Jan 26, 2024

Conversation

danielgblanco
Copy link
Contributor

Fixes #3829

Changes

  • Adds clarification on measurement processing for metric views and their relation the resulting metric streams, particularly when multiple views match the same instrument
  • Fixes example that should generate a warning of conflicting metric identities
  • Adds example for drop aggregation as a non-conflicting metric view

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @danielgblanco!

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good examples to clarify!

@danielgblanco
Copy link
Contributor Author

Thanks both. I don't have write access on this repo so feel free to merge whenever you think it's good to go :)

@reyang
Copy link
Member

reyang commented Jan 24, 2024

Thanks both. I don't have write access on this repo so feel free to merge whenever you think it's good to go :)

FYI, we follow this process https://github.com/open-telemetry/opentelemetry-specification/blob/main/CONTRIBUTING.md#how-to-get-your-pr-merged.

specification/metrics/sdk.md Outdated Show resolved Hide resolved
@reyang reyang merged commit 518bea8 into open-telemetry:main Jan 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarification around the relationship between metric views and metric streams
5 participants