Clarify differences between prometheus protocols, including target info metric naming #3871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
clarify_prometheus_protocols
branch
from
f0283d5
to
f0d715f
Compare
dashpole
changed the title
|
@open-telemetry/wg-prometheus |
jsuereth
approved these changes
Feb 8, 2024
yurishkuro
reviewed
Feb 8, 2024
Correct. This is keeping the same behavior, and is just trying to make the existing spec easier to read. The only hesitation I have with the current spec is that if Prometheus text format adds an |
jmacd
approved these changes
Feb 14, 2024
eero-t
reviewed
Feb 19, 2024
dashpole
force-pushed
the
clarify_prometheus_protocols
branch
from
b74502b
to
c968605
Compare
MrAlias
approved these changes
Feb 22, 2024
pellared
approved these changes
Feb 28, 2024
Aneurysm9
reviewed
Feb 29, 2024
…eus and OpenMetrics in the spec
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Co-authored-by: Eero Tamminen <eero.t.tamminen@intel.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com> Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Aneurysm9
approved these changes
Feb 29, 2024
dashpole
force-pushed
the
clarify_prometheus_protocols
branch
from
6608bab
to
cf3fda7
Compare
bogdandrutu
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3700
Changes
The current specification mixes OpenMetrics and Prometheus in ways that can be confusing. This change first explains the differences between various Prometheus formats, and then consistently uses "Prometheus" to refer to the general conversion rules. This is helpful for explaining why the target (info) metric naming differs depending on the format used.
Also, fix references to the "target" info-typed metric, which was previously referred to as "target_info". "target_info" is only used when info-typed metrics are not supported.