Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[configuration] Fix regular expression and specify syntax used #4001

Merged
merged 4 commits into from Apr 23, 2024
Merged

[configuration] Fix regular expression and specify syntax used #4001

merged 4 commits into from Apr 23, 2024

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Apr 18, 2024 •
edited

Changes

  • Escapes both start and end braces in regular expression for consistency; it seems like both escaping or not escaping would work per https://regex101.com/r/YH667H/1
  • Specifies regex syntax to avoid ambiguity

I am not sure whether this warrants a changelog

@mx-psi mx-psi requested review from a team as code owners April 18, 2024 15:20
@arminru arminru requested a review from a team April 18, 2024 16:00
@jack-berg jack-berg mentioned this pull request Apr 18, 2024
Merged
2 tasks
@arminru arminru merged commit 2dbe9f6 into open-telemetry:main Apr 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jack-berg jack-berg jack-berg approved these changes

@MrAlias MrAlias MrAlias approved these changes

@arminru arminru arminru approved these changes

@reyang reyang reyang approved these changes

Assignees

@bogdandrutu bogdandrutu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mx-psi @MrAlias @arminru @reyang @jack-berg @bogdandrutu