Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify possibility to extend SDK interfaces #4030

Merged
merged 15 commits into from
Jun 6, 2024

Conversation

JonasKunz
Copy link
Contributor

@JonasKunz JonasKunz commented May 2, 2024

Split out from #4024 (see this comment).

I've attempted to merge the clarifications with the existing Extending API Calls section and tried to soften the wording to be less prescriptive.

Changes

Clarifies that it is permissible to extend SDK interface without warranting a new major version.

@JonasKunz JonasKunz marked this pull request as ready for review May 2, 2024 10:09
@JonasKunz JonasKunz requested review from a team as code owners May 2, 2024 10:09
@tigrannajaryan
Copy link
Member

I wrote a draft on this topic a while back that goes into a bit more details and nuances.

My be worth reviewing it and we can decide if we want to pursue it.

@JonasKunz
Copy link
Contributor Author

@tigrannajaryan your draft indeed seems to cover my intent of this PR, but with a lot more detail.
I'd suggest that if we want to pursue having this in the spec, I'll close this PR in favour of a PR based on your draft opened by you?

@tigrannajaryan
Copy link
Member

I'll close this PR in favour of a PR based on your draft opened by you?

@JonasKunz I won't be able to open a PR myself. If you'd like to continue working on this yourself please feel free to borrow any content from my doc.

Co-authored-by: Robert Pająk <pellared@hotmail.com>
@JonasKunz
Copy link
Contributor Author

I'll close this PR in favour of a PR based on your draft opened by you?

@JonasKunz I won't be able to open a PR myself. If you'd like to continue working on this yourself please feel free to borrow any content from my doc.

@tigrannajaryan unfortunately I currently too don't have the capacity for this topic to that level of depth. I'll try to take some inspiration from your doc, but will keep the changes minimal and focused for the use case #4024. We can then later revisit with more details in follow-up PRs.

Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 25, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
specification/versioning-and-stability.md Show resolved Hide resolved
@pellared pellared removed the Stale label May 29, 2024
Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reyang reyang merged commit 9758cdd into open-telemetry:main Jun 6, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants