Clarify semantic conventions around span start and end time #592
Conversation
toumorokoshi
requested review from
arminru,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
jmacd,
reyang,
SergeyKanzhelev,
tedsuo,
tigrannajaryan and
yurishkuro
as code owners
I think that's fair. for http in particular web servers (and sometimes clients) incorporate some common middleware that adds to the cost of the request. I felt like the most ambiguity was there. I could take a stab at clarifying this is a more general place. |
Feedback states that the clarification around the meaning of the span start and end times could be more generic. Starting a proposal around by adding an example to the API.
toumorokoshi
changed the title
|
One thing to consider is to make the Http example a more general RPC one. No strong feeling though. Overall good as an example ;) |
Rewording recommendation to use a more generic RPC Adding a small blurb clarifying sub operations can be instrumented.
toumorokoshi
force-pushed
the
feature/span-duration-conventions
branch
from
1797a7d
to
8099078
Compare
done! rewritten to a more generic RPC. |
|
Please resolve comments so we can get this merged :) |
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com> Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
|
@bogdandrutu addressed! |
|
@bogdandrutu these are addressed now, thanks! |
carlosalberto
added
spec:trace
…emetry#592) * Adding http semantic conventions for span start and end times. * Corrected send to end, further clarified timings. * Moving span operation clarification to api Feedback states that the clarification around the meaning of the span start and end times could be more generic. Starting a proposal around by adding an example to the API. * Addressing feedback Rewording recommendation to use a more generic RPC Adding a small blurb clarifying sub operations can be instrumented. * Apply suggestions from code review Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com> Co-authored-by: Christian Neumüller <christian+github@neumueller.me> * Expanding on child spans Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com> Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
Fixes #591.
Adding semantic conventions for http start and end times. This has previously caused some ambiguity in the start / end times that instrumentations should target.