Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ParentOrElse to ParentBased and generalize to support all cases #610

Merged
merged 4 commits into from
Aug 21, 2020
Merged

Rename ParentOrElse to ParentBased and generalize to support all cases #610

merged 4 commits into from
Aug 21, 2020
+30 −15

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented May 18, 2020 •
edited
Loading

No description provided.

@Oberon00 Oberon00 mentioned this pull request May 19, 2020
Closed
@garthk garthk mentioned this pull request May 20, 2020
Open
@jmacd jmacd added the area:sampling Related to trace sampling label May 29, 2020
@Oberon00 Oberon00 mentioned this pull request Jun 2, 2020
Open
@carlosalberto carlosalberto added spec:trace Related to the specification/trace directory area:sdk Related to the SDK labels Jun 19, 2020
@carlosalberto carlosalberto added the release:required-for-ga Must be resolved before GA release, or nice to have before GA label Jul 7, 2020
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 12, 2020
@bogdandrutu bogdandrutu requested review from a team as code owners August 19, 2020 19:02
@bogdandrutu bogdandrutu changed the title Add ParentNotRemoteOrElse and fix Probability sampler definition Rename ParentOrElse to ParentBased and generalize to support all cases Aug 19, 2020
@bogdandrutu
Copy link
Member Author

@carlosalberto please review again, because I incorporated the feedback from @Oberon00.

@bogdandrutu
Add ParentNotRemoteOrElse and fix Probability sampler definition
ccf7ff5 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@carlosalberto
Copy link
Contributor

(The latest) improvements look good!

@yurishkuro Please approve if you think all your issues are solved (else, comment ;) )

@bogdandrutu bogdandrutu removed the Stale label Aug 20, 2020
@arminru arminru mentioned this pull request Aug 21, 2020
Merged
@bogdandrutu bogdandrutu merged commit f089eba into open-telemetry:master Aug 21, 2020
@bogdandrutu bogdandrutu deleted the parentnotremote branch August 21, 2020 14:40
carlosalberto added a commit to carlosalberto/opentelemetry-specification that referenced this pull request Aug 21, 2020
@carlosalberto
Add CHANGELOG entry for open-telemetry#610
7c8626c
@carlosalberto carlosalberto mentioned this pull request Aug 21, 2020
Merged
carlosalberto added a commit that referenced this pull request Aug 21, 2020
@carlosalberto @arminru
Add CHANGELOG entry for #610 (#852)
36f13ae 
* Add CHANGELOG entry for #610

* Update CHANGELOG.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
@dyladan dyladan mentioned this pull request Aug 21, 2020
Closed
@jtescher jtescher mentioned this pull request Aug 21, 2020
Closed
@jkwatson jkwatson mentioned this pull request Aug 21, 2020
Closed
@fbogsany fbogsany mentioned this pull request Aug 24, 2020
Merged
@reyang reyang mentioned this pull request Aug 24, 2020
Closed
@MrAlias MrAlias mentioned this pull request Aug 24, 2020
Closed
@lzchen lzchen mentioned this pull request Aug 25, 2020
Closed
@matej-g matej-g mentioned this pull request Sep 9, 2020
Merged
@bobstrecansky bobstrecansky mentioned this pull request Sep 15, 2020
Closed
@prondubuisi prondubuisi mentioned this pull request Sep 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oberon00 Oberon00 Oberon00 left review comments

@carlosalberto carlosalberto carlosalberto approved these changes

@yurishkuro yurishkuro yurishkuro approved these changes

@arminru arminru arminru approved these changes

@c24t c24t Awaiting requested review from c24t

@iredelmeier iredelmeier Awaiting requested review from iredelmeier

@jmacd jmacd Awaiting requested review from jmacd

@reyang reyang Awaiting requested review from reyang

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@tedsuo tedsuo Awaiting requested review from tedsuo

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan

Assignees

@carlosalberto carlosalberto

Labels
area:sampling Related to trace sampling area:sdk Related to the SDK release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:trace Related to the specification/trace directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bogdandrutu @carlosalberto @Oberon00 @yurishkuro @arminru @jmacd