Setting naming convention for exporter packages #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an implicit convention around exporter packages in several language instrumentations. Adding the convention to the spec standardizes the convention.
toumorokoshi
requested review from
arminru,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
jmacd,
reyang,
SergeyKanzhelev,
tedsuo,
tigrannajaryan and
yurishkuro
as code owners
jtescher
reviewed
Jun 1, 2020
arminru
approved these changes
Jun 9, 2020
There was a problem hiding this comment.
Please make sure to add an entry in the changelog:
https://github.com/open-telemetry/opentelemetry-specification/blob/master/CHANGELOG.md#unreleased
- modifying wording for exporter packages to have prefixes - fixing link naming - adding entry to changelog
carlosalberto
approved these changes
Jun 11, 2020
|
@toumorokoshi please rebase and fix all comments :) |
carlosalberto
added
the
area:semantic-conventions
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
|
@bogdandrutu done! |
jmacd
approved these changes
Jun 12, 2020
bogdandrutu
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an implicit convention around exporter packages in several
language instrumentations. Adding the convention to the spec standardizes
the convention.