Use a common attribute interface #717
Conversation
| A resource is made by a collection of attributes. Resources MUST use the same | ||
| `Attribute` definition used for [Span Attributes](../trace/api.md#set-attributes). |
There was a problem hiding this comment.
| A resource is made by a collection of attributes. Resources MUST use the same | |
| `Attribute` definition used for [Span Attributes](../trace/api.md#set-attributes). | |
| A resource is a collection of [Attributes](../trace/api.md#set-attributes). | |
| Resources MUST allow the same value types as Spans. |
There was a problem hiding this comment.
s/"A resource is a collection of attributes"/"A resource is represented by a collection of attributes"/
| of: string, int64, double, bool. | ||
| - a collection of [attributes](../trace/api.md#set-attributes). | ||
|
|
||
| Attribute values of `null` are considered to be used to create the resource and |
There was a problem hiding this comment.
I don't understand this sentence.
Should we also reference the null handling of spans here?
There was a problem hiding this comment.
+1. What is the motivation for this?
There was a problem hiding this comment.
I suspect this has to do with the pre-existing definition of Merge? null is not a valid attribute value, so this seems unnecessary to state. (OTOH, I'd like it to be a valid attribute value, but it would still be unnecessary.)
There was a problem hiding this comment.
Since we link the definition of Attributes used by setAttributes, I wanted to state that for resources, null values should be handled slightly differently.
| The SDK must support two ways to instantiate new resources. Those are: | ||
| A resource is made by a collection of attributes. Resources MUST use the same | ||
| `Attribute` definition used for [Span Attributes](../trace/api.md#set-attributes). | ||
| The SDK MUST support two ways to instantiate new resources. Those are: |
There was a problem hiding this comment.
Those are:
You can't use semicolon to refer to sections. Instead, say "The SDK MUST support two ways to instantiate new resources: Create and Merge". It also makes the sentence self-contained, you don't need to read through to understand what those two ways are.
|
Alternative approach proposed here #722 |
|
@Oberon00 I did extract the attributes without seeing the comment, but I think it makes sense |
|
Closing in favor of #722 |
Fixes #446 conforming the Attribute definition also for Resources