Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sampler.ShouldSample parent parameter to be Context #881

Merged
merged 10 commits into from
Oct 20, 2020
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,8 @@ Updates:
([#984](https://github.com/open-telemetry/opentelemetry-specification/pull/984)
- Metrics SDK: Specify TBD default aggregation for ValueRecorder
([#984](https://github.com/open-telemetry/opentelemetry-specification/pull/984)
- Trace SDK: Sampler.ShouldSample gets parent Context instead of SpanContext
([#881](https://github.com/open-telemetry/opentelemetry-specification/pull/881))
- SDK: Specify known values, as well as basic error handling for OTEL_PROPAGATORS.
([#962](https://github.com/open-telemetry/opentelemetry-specification/pull/962))
([#995](https://github.com/open-telemetry/opentelemetry-specification/pull/995))
Expand Down
1 change: 1 addition & 0 deletions spec-compliance-matrix.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ status of the feature is not known.
|RecordException with extra parameters | - | + | + | [-](https://github.com/open-telemetry/opentelemetry-python/issues/1102) | - | - | | + | - | + |
|[Sampling](https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/sdk.md#sampling)|
|Allow samplers to modify tracestate | | | | [-](https://github.com/open-telemetry/opentelemetry-python/issues/1220) | | | | | | |
|ShouldSample gets full parent Context | | | | | | | | | | |

## Baggage

Expand Down
3 changes: 2 additions & 1 deletion specification/trace/sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ Returns the sampling Decision for a `Span` to be created.

**Required arguments:**

* Parent `SpanReference`. May be invalid to indicate a root span.
* [`Context`](../context/context.md) with parent `Span`.
Oberon00 marked this conversation as resolved.
Show resolved Hide resolved
The Span's SpanContext may be invalid to indicate a root span.
* `TraceId` of the `Span` to be created.
If the parent `SpanReference` contains a valid `TraceId`, they MUST always match.
* Name of the `Span` to be created.
Expand Down