Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yaml semantic conventions for Exception #927

Merged

Conversation

thisthat
Copy link
Member

@thisthat thisthat commented Sep 7, 2020

Changes

Updated Exception semantic convention to the YAML format.

Related issues #547

@arminru arminru linked an issue Sep 8, 2020 that may be closed by this pull request
semantic_conventions/trace/exception.yaml Outdated Show resolved Hide resolved
semantic_conventions/trace/exception.yaml Outdated Show resolved Hide resolved
@Oberon00 Oberon00 added area:semantic-conventions Related to semantic conventions spec:trace Related to the specification/trace directory area:error-reporting Related to error reporting labels Sep 9, 2020
@carlosalberto
Copy link
Contributor

@thisthat Please rebase and resolve the conflicts ;)

@thisthat
Copy link
Member Author

@carlosalberto done in 22bbb9b :)

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking just to understand clearly the intent regarding exception.stacktrace. The PR itself is highly welcome, but I think the way the example is rendered makes it confusing.

@Oberon00
Copy link
Member

Indeed it seems like the \n are not doing what they should inside the ''.

@thisthat
Copy link
Member Author

thisthat commented Sep 14, 2020

@tigrannajaryan could you please explain better the problem? Do you want the example to be encapsulated in quotes?
@Oberon00 also in the previous version the example had \n that were not rendered as new lines

@tigrannajaryan
Copy link
Member

I think the original example was also misleading. I expect not to see any literal \n characters in the example and I expect not to see backslaches before double quote characters.
It needs to be fixed, but I am fine if it is fixed in a future PR.

@thisthat
Copy link
Member Author

@tigrannajaryan I've created #951 to track the example change

@carlosalberto carlosalberto merged commit 697e3b1 into open-telemetry:master Sep 15, 2020
@arminru arminru deleted the yaml-exception branch September 15, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:error-reporting Related to error reporting area:semantic-conventions Related to semantic conventions spec:trace Related to the specification/trace directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Define semantic conventions in JSON/YAML
5 participants