Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typos and and Minor Code Adjustments #515

Merged

Conversation

aldoKelvianto
Copy link
Contributor

This pull request tries to improve the opentelemetry-swift project's documentation by correcting spelling mistakes and making minor readability enhancements in various source and test files.

An example of these corrections is in the OpenTelemetryApi, which is frequently read by SDK users. For instance, upon reviewing the SpanKind enum, I noticed that the letter I in Indicates was missing.

Thank you for considering these adjustments.

Copy link

linux-foundation-easycla bot commented Feb 5, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: aldoKelvianto / name: Aldo Wachyudi (82d3f07)
  • ✅ login: nachoBonafonte / name: Ignacio Bonafonte (8474be3)

Copy link
Member

@nachoBonafonte nachoBonafonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for your contribution.

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (297d91f) 66.34% compared to head (8474be3) 66.34%.

Files Patch % Lines
...s/Stable/Aggregation/LongLastValueAggregator.swift 0.00% 3 Missing ⚠️
...s/Stable/Exemplar/HistogramExemplarReservoir.swift 0.00% 2 Missing ⚠️
...ntation/URLSession/URLSessionInstrumentation.swift 0.00% 1 Missing ⚠️
...Stable/Aggregation/DoubleLastValueAggregator.swift 66.66% 1 Missing ⚠️
...rics/Stable/Aggregation/LastValueAggregation.swift 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #515   +/-   ##
=======================================
  Coverage   66.34%   66.34%           
=======================================
  Files         336      336           
  Lines       14466    14466           
=======================================
  Hits         9597     9597           
  Misses       4869     4869           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nachoBonafonte nachoBonafonte merged commit 613b64d into open-telemetry:main Feb 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants