Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n] Support non-English banners with English fallback #4486

Closed
Tracked by #4467
chalin opened this issue May 15, 2024 · 1 comment · Fixed by #4625
Closed
Tracked by #4467

[i18n] Support non-English banners with English fallback #4486

chalin opened this issue May 15, 2024 · 1 comment · Fixed by #4625
Assignees
@chalin
Labels
enhancement New feature or request i18n internationalization
Milestone
24Q2

Comments

@chalin
Copy link
Contributor

chalin commented May 15, 2024 •
edited

Add support for homepage banner announcements.

Originally posted by @windsonsea in #2402 (comment)

Could we provide a placeholder-alike? If no localized zh text, use the en banner; if localized, use the zh banner.

@svrnm wrote:

Yes, having the English banner would be great. They are often short lived but important, so providing a translation everytime might not be possible
@chalin chalin added enhancement New feature or request lang:zh labels May 15, 2024
@chalin chalin self-assigned this May 15, 2024
@chalin
Copy link
Contributor Author

chalin commented May 15, 2024

I have some ideas about how to implement this with Hugo's base features (rather than writing custom Hugo code). I'll probably work on this after I fix the canonical links issue

@chalin chalin mentioned this issue May 15, 2024
Open
23 tasks
@chalin chalin added this to the 24Q2 milestone May 15, 2024
This was referenced May 19, 2024
Open
Open
This was referenced May 22, 2024
Open
Open
@chalin chalin changed the title [zh] Support Chinese banners with English fallback [i18n] Support non-English banners with English fallback Jun 7, 2024
@chalin chalin added i18n internationalization and removed lang:zh labels Jun 7, 2024
@chalin chalin mentioned this issue Jun 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chalin chalin

Labels
enhancement New feature or request i18n internationalization
Projects
None yet
Milestone
24Q2
Development

Successfully merging a pull request may close this issue.

[i18n] Support automatic banner management across localizations chalin/opentelemetry.io
1 participant
@chalin