Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chinese version of website #2402

Closed
7 tasks done
Tracked by #4082
laziobird opened this issue Feb 25, 2023 · 22 comments · Fixed by #4477
Closed
7 tasks done
Tracked by #4082

Add Chinese version of website #2402

laziobird opened this issue Feb 25, 2023 · 22 comments · Fixed by #4477
Assignees
Labels
CI/infra CI & infrastructure docs e1-hours Effort: < 8 hrs enhancement New feature or request i18n internationalization lang:zh
Milestone

Comments

@laziobird
Copy link

laziobird commented Feb 25, 2023

Desired feature or idea.
What would you like to see happen?
There are many developers who are always focus on OpenTelemetry in China. 😊
We already have a Chinese project in OpenTelemetry GitHub : https://github.com/open-telemetry/docs-cn.
As a maintainer, i try a better way to spread OpenTelemetry in China.
Our community team want to contribute the Chinese official documents in OpenTelemetry.io . I suggest that whether we can add a link in OpenTelemetry.io , which is from the Chinese official introduction project https://github.com/open-telemetry/docs-cn.

Additional context
Anything else you can think about that would be helpful.
I think it is a good way to preach the Technology of OpenTelemetry Observability and bring everyone's more passions in China community . I have already communicated with Ted for the topic ,and he is very nice and suggested me to file an issue .
Looking forward your suggestion too.


Tasks

Followup items:

@cartermp cartermp added CI/infra CI & infrastructure i18n internationalization discussion Input from everyone is helpful to drive this forward labels Feb 26, 2023
@cartermp
Copy link
Contributor

Wow, this is a really great initiative. I think we'd have to discuss what it would mean to have a Chinese version of the site, or at least the site's content.

I can see in the repo you linked that there's content there that summarizes some of the concepts in a different way than we do in this repo. That's both fantastic and a bit of a challenge -- we may need to work out a plan to merge content so that both the Chinese and English versions have the same content.

Some topics that come to mind that we'd have to work out:

  • Differences in content and how to move forward with that
  • How to handle site maintenance
  • How to adjust a contribution flow - for example, someone contributes content in English, how do we port to Chinese?
  • Multiple SIGs?

@chalin and @svrnm how would you like to proceed?

@chalin
Copy link
Contributor

chalin commented Feb 26, 2023

My first thoughts & comments:

  • As you probably know, Hugo + Docsy have support for multilingual sites.
  • We anticipated that other languages would come along and put the English docs under content/en already.
  • As a trial, we could mount the docs-cn under content/cn as is, and enable the (natural) language version menu.

I think that there are two main ways to approach this. One is to just mount docs-cn as is (with it's different structure), but ideally, both language versions should have the same structure because we'll then be able to setup the cn version of the docs to fall back to the en version when no cn page is present. That way, both sets of docs have all the pages, supporting an incremental translation of the docs.

@svrnm
Copy link
Member

svrnm commented Feb 27, 2023

Hey @laziobird , thanks! I agree with @cartermp that this is a great initiative and definitely something we should have, so we need to discuss the how we can have it, as @chalin outlined it already.

I agree with @chalin that ideally the two should have the same structure (and maybe even live out of the same repo?), I see us having more languages in the future so we should start with a good practice now.

@laziobird would you be able to attend one of our SIG meetings, there is one today at 10 am PST, not sure if this works for you? Otherwise we can discuss it async via the slack channel

@laziobird
Copy link
Author

Hey @laziobird , thanks! I agree with @cartermp that this is a great initiative and definitely something we should have, so we need to discuss the how we can have it, as @chalin outlined it already.

I agree with @chalin that ideally the two should have the same structure (and maybe even live out of the same repo?), I see us having more languages in the future so we should start with a good practice now.

@laziobird would you be able to attend one of our SIG meetings, there is one today at 10 am PST, not sure if this works for you? Otherwise we can discuss it async via the slack channel

@svrnm Thanks for your invitation !I probably can't attend this meetings , i hope to discuss it async via the slack channel continue . I would like to attend next SIG meeting though my English speaking and listening are a little poor ,if you don't mind this . 😊

@svrnm
Copy link
Member

svrnm commented Feb 28, 2023

@laziobird no worries, I understand that. We can keep it async here or in the slack, whatever you prefer.

@laziobird
Copy link
Author

My first thoughts & comments:

  • As you probably know, Hugo + Docsy have support for multilingual sites.
  • We anticipated that other languages would come along and put the English docs under content/en already.
  • As a trial, we could mount the docs-cn under content/cn as is, and enable the (natural) language version menu.

I think that there are two main ways to approach this. One is to just mount docs-cn as is (with it's different structure), but ideally, both language versions should have the same structure because we'll then be able to setup the cn version of the docs to fall back to the en version when no cn page is present. That way, both sets of docs have all the pages, supporting an incremental translation of the docs.

I very agree it . It is necessary to keep the uniform structure . I would like to be open to support cn version of the docs .

@laziobird
Copy link
Author

We see a good example : istio
This is en version
https://istio.io/latest/
This is cn version
https://istio.io/latest/zh/docs/
You know , number of documents is big , and sometime they are changed frequently.
Maybe we can translate the core and main documents first , that give a fast way to preach OpenTelemetry in Chinese community and encourage all members to distribute some contents. These contributors who are response for translating must understand OpenTelemetry and Observability much more .
So we need some time and patience . 😊

@svrnm
Copy link
Member

svrnm commented Mar 4, 2023

@laziobird what we need to continue with this, is an understanding of how many people are there who are willing to help building the chinese version? We need a critical mass of people, who are willing to help with that, to be sure that we can maintain and run this long term, since the existing maintainers are not able to help with that.

Maybe we can translate the core and main documents first ,

Yes, I think there are some pages which are more important than others (https://opentelemetry.io/, https://opentelemetry.io/docs/concepts/, https://opentelemetry.io/docs/getting-started/ are the ones that should be there first, then the getting started for collector & all languages, etc., that's at least my suggestion)

@chalin chalin changed the title An idea for add the Chinese version for website documents in opentelemetry.io Add Chinese version of website Mar 14, 2023
@Petrie
Copy link
Contributor

Petrie commented Mar 30, 2023

@laziobird Is there any recent progress on this topic?
As a native Chinese speaker, I would be delighted to contribute to the creation of a Chinese version.

@laziobird
Copy link
Author

@laziobird Is there any recent progress on this topic? As a native Chinese speaker, I would be delighted to contribute to the creation of a Chinese version.

Hi:
Petrie, you can join in the slack channel https://join.slack.com/t/opentelemetry-china/shared_invite/zt-1rzmuyguc-N9DI692M4aa4AlmYr1vfdA . And we can communicate with each other deeply if you are interesting with this plan . My account is 蒋志伟 in slack .

@windsonsea
Copy link
Member

windsonsea commented Jun 5, 2023

Cool! You already have so many Chinese pages. Could we use a simple structure like:

https://github.com/open-telemetry/opentelemetry.io/tree/main/content/en
https://github.com/open-telemetry/opentelemetry.io/tree/main/content/zh
https://github.com/open-telemetry/opentelemetry.io/tree/main/content/de
...

It's not easy to find the docs-cn repository among the 63 repositories if I didn't receive tips from @svrnm.

@svrnm
Copy link
Member

svrnm commented Jun 6, 2023

@laziobird @windsonsea @open-telemetry/docs-cn-approvers unfortunately I don't have insights how the docs-cn project came around and what the status of it is.

To provide you some guidance on how we can accomplish a translation accessible via opentelemetry.io:

  • Our website supports multiple languages already, so the translated content should live under main/content/<two_letter_code> (as @windsonsea pointed out already)
  • Our point of reference is how kubernetes is doing their localization, see https://github.com/kubernetes/website
  • We need at least 2 ppl owning that content, so that changes can be approved (CODEOWNERSHIP will help with that)
  • We can start with the translation been hidden until we reach a point where enough material is translated to go live (with maybe some blog post & announcements around it)

Please anticipate that this is guidance on not a fixed set of rules: Chinese will the first language besides English we translate, so there might be some roadblockers we do not anticipate yet.

@svrnm
Copy link
Member

svrnm commented Apr 16, 2024

See #4302 for future discussions on this matter.

@svrnm svrnm closed this as completed Apr 16, 2024
@chalin
Copy link
Contributor

chalin commented May 7, 2024

Reopening since this work has started.

@chalin chalin reopened this May 7, 2024
@chalin chalin added this to the 24Q2 milestone May 8, 2024
@chalin chalin added enhancement New feature or request docs e1-hours Effort: < 8 hrs and removed discussion Input from everyone is helpful to drive this forward labels May 8, 2024
@chalin
Copy link
Contributor

chalin commented May 10, 2024

@chalin
Copy link
Contributor

chalin commented May 10, 2024

All: after thinking about this more carefully, I'd like to make the following proposal:

  • zh site pages should live in another repo, that we would bring in here via a submodule

It could be open-telemetry/docs-cn or a new repo.

As maintainers know, there are advantages and disadvantages to the submodule approach vs. having the pages in this repo. I'm thinking that during the initial (potentially most intense) ramp up phase of bring in zh pages, it might be helpful to do so in a manner that is quantized, much like what we do for the specifications: e.g., we update spec repos when there is an official release. We could consider doing so for the zh pages too, at least for an initial period.

Thoughts @open-telemetry/docs-approvers @open-telemetry/docs-cn-approvers?

I'm not strongly in favor of either approach, I just wanted to articulate the submodule option in case some of you would consider it preferable (or at least worth trying).

@theletterf
Copy link
Member

I like the idea of a different repository for the mentioned reasons.

Ultimately, I'd rather follow the preference of @open-telemetry/docs-cn-approvers , as they surely have preferences in terms of localization process, etc.

@svrnm
Copy link
Member

svrnm commented May 13, 2024

I am conflicted, but overall I have a strong preference for not having the Chinese (or any other documentation) outside the opentelemetry.io repository for now:

  • Making this decision now feels premature, and reverting it is much harder than creating the repository later if we find out it's the right thing to do
  • Until we have gained some experience with localization I'd like to keep this close to docs approvers/maintainers who know the inner workings of the docs. Having translators work from their own repo requires us to take a look at them consistently as well.

I see the point that having more control over the release of translated pages, however I am not sure how to define when we update the releases and when not? We also do not do that for the English pages as of today and live with a set of bugs and issues. We might at some point in the future think about releasing the website vs having hot-updates, but not today.

I think we should keep things as is for today, but re-evaluate the situation in 3-6 months from now

@chalin
Copy link
Contributor

chalin commented May 13, 2024

I'm ok with rolling with what we have now, which is the pages living in this repo.

@chalin
Copy link
Contributor

chalin commented May 13, 2024

Should English banners show up on the zh homepage? That's how it is currently setup. It might seem reasonable to include the English banners when the Chinese versions aren't available?

@windsonsea
Copy link
Member

windsonsea commented May 14, 2024

Could we provide a placeholder-alike? If no localized zh text, use the en banner; if localized, use the zh banner.

@chalin chalin mentioned this issue May 14, 2024
20 tasks
@svrnm
Copy link
Member

svrnm commented May 15, 2024

Yes, having the English banner would be great. They are often short lived but important, so providing a translation everytime might not be possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure docs e1-hours Effort: < 8 hrs enhancement New feature or request i18n internationalization lang:zh
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants