.NET manual: independent and new root docs #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
commented
Oct 14, 2022
cijothomas
reviewed
Oct 15, 2022
cijothomas
reviewed
Oct 15, 2022
cijothomas
reviewed
Oct 15, 2022
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
cartermp
commented
Oct 15, 2022
svrnm
reviewed
Oct 17, 2022
svrnm
reviewed
Oct 17, 2022
svrnm
reviewed
Oct 17, 2022
svrnm
reviewed
Oct 17, 2022
reyang
requested changes
Oct 17, 2022
There was a problem hiding this comment.
The code example seems to be very complicated. I feel that we should encourage best practices in the doc which help to create a pit of success, please find my suggestion here https://github.com/open-telemetry/opentelemetry.io/pull/1867/files#r997371774
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
|
@reyang Sorry for not pinging, thought I had. Can you take another look to see if the changes are suitable? |
|
@reyang any chance to take another look? Looking to get through our open PRs this week. |
chalin
approved these changes
Nov 3, 2022
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1073 and brings the manual instrumentation bit up to par with JS.