Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend Overhaul blog post #1877

Merged
merged 17 commits into from
Nov 3, 2022

Conversation

xoscar
Copy link
Contributor

@xoscar xoscar commented Oct 18, 2022

Hello everyone,

Our team wrote a blog post about the frontend changes a couple of weeks ago, and there were some ideas on possibly having the post added to the open telemetry website as well. We have made some changes to make it vendor-free and better suited for the open telemetry website.

Let me know if you have any questions or concerns!


Preview: https://deploy-preview-1877--opentelemetry.netlify.app/blog/2022/frontend-overhaul/

@xoscar xoscar requested review from a team as code owners October 18, 2022 18:56
Copy link
Member

@melbgirl melbgirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly language changes/rewording to improve flow and readability.

content/en/blog/2022/frontend-overhaul/index.md Outdated Show resolved Hide resolved
content/en/blog/2022/frontend-overhaul/index.md Outdated Show resolved Hide resolved
content/en/blog/2022/frontend-overhaul/index.md Outdated Show resolved Hide resolved
content/en/blog/2022/frontend-overhaul/index.md Outdated Show resolved Hide resolved
content/en/blog/2022/frontend-overhaul/index.md Outdated Show resolved Hide resolved
content/en/blog/2022/frontend-overhaul/index.md Outdated Show resolved Hide resolved
content/en/blog/2022/frontend-overhaul/index.md Outdated Show resolved Hide resolved
content/en/blog/2022/frontend-overhaul/index.md Outdated Show resolved Hide resolved
content/en/blog/2022/frontend-overhaul/index.md Outdated Show resolved Hide resolved
content/en/blog/2022/frontend-overhaul/index.md Outdated Show resolved Hide resolved
@svrnm svrnm added the blog label Oct 19, 2022
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @xoscar!

@open-telemetry/demo-approvers please give this a look as well

content/en/blog/2022/frontend-overhaul/index.md Outdated Show resolved Hide resolved
content/en/blog/2022/frontend-overhaul/index.md Outdated Show resolved Hide resolved
content/en/blog/2022/frontend-overhaul/index.md Outdated Show resolved Hide resolved
content/en/blog/2022/frontend-overhaul/index.md Outdated Show resolved Hide resolved
content/en/blog/2022/frontend-overhaul/index.md Outdated Show resolved Hide resolved
@svrnm svrnm requested review from a team October 19, 2022 09:44
@xoscar
Copy link
Contributor Author

xoscar commented Oct 19, 2022

Hello @melbgirl & @svrnm thanks for your review! I really appreciate it 😄

I have addressed all of your comments, let me know if there is anything else I can do. Cheers!

@xoscar xoscar requested review from melbgirl and svrnm and removed request for melbgirl October 19, 2022 15:23
@xoscar
Copy link
Contributor Author

xoscar commented Oct 20, 2022

Hello @reyang thanks for your feedback, I think I got it all fixed now. Let me know if there is something else I can do! 😄

@svrnm
Copy link
Member

svrnm commented Oct 24, 2022

TY @xoscar , minor NIT: the image system-diagram.png has some visual icons on the top right corner that make PHP invisible, can you fix that please?

@svrnm
Copy link
Member

svrnm commented Oct 24, 2022

@open-telemetry/blog-approvers , please review & approve

content/en/blog/2022/frontend-overhaul/index.md Outdated Show resolved Hide resolved
@cartermp
Copy link
Contributor

@open-telemetry/blog-approvers PTAL!

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline for question and minor copy-edit.

content/en/blog/2022/frontend-overhaul/index.md Outdated Show resolved Hide resolved
content/en/blog/2022/frontend-overhaul/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment for a suggested change that will fix the build.

content/en/blog/2022/frontend-overhaul/index.md Outdated Show resolved Hide resolved
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@xoscar
Copy link
Contributor Author

xoscar commented Nov 2, 2022

@chalin I don't want to be pushy but, is there something else I can do to have this one merged? 😄

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggested (and optional) short-title tweak. Otherwise LGTM ✨

content/en/blog/2022/frontend-overhaul/index.md Outdated Show resolved Hide resolved
@chalin
Copy link
Contributor

chalin commented Nov 2, 2022

@xoscar - @svrnm and @cartermp will time the merge (and tweak the publish date?), once ready. I've given my final approval, thanks.

Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@cartermp
Copy link
Contributor

cartermp commented Nov 3, 2022

Thanks @xoscar! We will un-draft this next Monday (discussed in Comms SIG) and have it get social media boostage.

@cartermp cartermp merged commit 946b73f into open-telemetry:main Nov 3, 2022
@xoscar xoscar deleted the frontend-overhaul-blog branch November 3, 2022 22:00
@xoscar
Copy link
Contributor Author

xoscar commented Nov 16, 2022

Hello @chalin @cartermp Do you know when the post will be published? if there is something I can do to help please let me know

CC: @kdhamric

@svrnm
Copy link
Member

svrnm commented Nov 16, 2022

@xoscar see #2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants