Adding TypeScript to "Getting Started"

[kaiwalyakoparkar]

Ref #1800 and #1888
@svrnm @chalin @cartermp kindly take a look

[cartermp]

Looks like you were right about the commits. Thanks for sticking it out like this. Looks like there's failures with respect to the main branch changes now, but once those are taken care of, I can approve.

[kaiwalyakoparkar]

Looks like you were right about the commits. Thanks for sticking it out like this. Looks like there's failures with respect to the main branch changes now, but once those are taken care of, I can approve.

Thanks for the information. It's been fixed 👍

[cartermp]

@open-telemetry/javascript-approvers PTAL!

[svrnm]

thanks for figthing this true! TY

[chalin]

Thanks. See inline comments, and questions for @svrnm and other reviewers.

[svrnm]

Really want to have this merged soon, @kaiwalyakoparkar can you give the reviews another look?:)

[kaiwalyakoparkar]

Really want to have this merged soon, @kaiwalyakoparkar can you give the reviews another look?:)

Sure, I will commit the required changes soon

[svrnm]

@open-telemetry/javascript-approvers please give this another look :-)

[legendecas]

Overall LGTM % some nits.

[legendecas]

I don't think browsers are able to load typescript source codes directly. For both JavaScript and TypeScript projects, here the src attribute value should be document-load.js (the output of tsc compilation).

[svrnm]

If I remember correctly parel (the build tool used in the example) will infer the type of the file from that and then do a proper compile and replacement. @kaiwalyakoparkar have you run through that example with TS and can verify, if not let's try this out.

[kaiwalyakoparkar]

Hey @svrnm I did run these files and can confirm that the output I received is according to the docs

[dyladan]

IMO it's quite confusing as parcel isn't mentioned until after the code samples. If you want to depend on bundler-specific behavior I would at least call it out at the top of the document that the samples will require some particular build process or dependency.

[svrnm]

@dyladan fair point! That one is on me, I wrote that tutorial initially. Let's have this in a separate (follow-up) issue

[cartermp]

I filed #1989 for this issue

[dyladan]

Code samples look good to me. I share @legendecas reservation about the ts extension when it isn't clear that this is enabled by build tooling

[dyladan]

IMO it's quite confusing as parcel isn't mentioned until after the code samples. If you want to depend on bundler-specific behavior I would at least call it out at the top of the document that the samples will require some particular build process or dependency.

[cartermp]

I will go ahead and merge, then we can address #1989 orthogonally, since it is all that remains. Thanks all, and especially @kaiwalyakoparkar for your diligence and patience across several PRs!