Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ruby docs approvers to relevant section in CODEOWNERS #1966

Merged
merged 1 commit into from Nov 3, 2022
Merged

Add ruby docs approvers to relevant section in CODEOWNERS #1966

merged 1 commit into from Nov 3, 2022

Conversation

cartermp
Copy link
Contributor

@cartermp cartermp commented Nov 3, 2022

Resolves #1942

@cartermp cartermp requested a review from a team as a code owner November 3, 2022 21:28
chalin
chalin approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

(I'm unsure if we want to insist that all language SIGs follow the same or a similar pattern of permitted code owners?)

@chalin chalin mentioned this pull request Nov 3, 2022
Closed
6 tasks
@cartermp
Copy link
Contributor Author

cartermp commented Nov 3, 2022

Heh, not sure either. I am fine with things how they are right now, though.

@cartermp cartermp merged commit 69d14d3 into main Nov 3, 2022
@cartermp cartermp deleted the cartermp-patch-2 branch November 3, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Ruby docs to this repo
2 participants
@cartermp @chalin