Make span kind description softer and closer the the spec #1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spec language is soft in regards of clients/server span relationships: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/api.md#spankind Server span does not need to have a parent, it could also be that multiple server implementations that are not aware of each other create server->server spans. While not ideal, this is a reality. Client spans can be nested under other client spans. E.g. DB ORM creates a client span and the underlying DB driver creates a client span. They are unaware of each other and have no knowledge if they are both enabled in the same application.
lmolkova
changed the title
cijothomas
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec language is soft in regards to clients/server span relationships:
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/api.md#spankind
Server span does not need to have a parent, it could also be that multiple server instrumentations that are not aware of each other create server->server spans. While not ideal, this is a reality.
Client spans can be nested under other client spans. E.g. DB ORM creates a client span and the underlying DB driver creates a client span. They are unaware of each other and have no knowledge if they are both enabled in the same application.