fix: typescript example application #2033
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing 2 minor issues I spotted in typescript Example Application:
npm install
lists theexpress
dependency twice, which is redundant. Removed one of these.app.listen()
on the expressapp
, the arrow function that prints a message to log should actually be a second parameter to thelisten
function. The parentheses are currently closed too early (after thePORT
parameter), causing no message to be output to the console as intended.parseInt
function on thePORT
is invoked in different patterns in js and ts examples (when extracting env variable in ts, and when invokingapp.listen
in js). I aligned them so the call is done in the same place for both examples