Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typescript example application #2033

Merged
merged 3 commits into from
Nov 21, 2022

Conversation

blumamir
Copy link
Member

@blumamir blumamir commented Nov 21, 2022

fixing 2 minor issues I spotted in typescript Example Application:

  1. npm install lists the express dependency twice, which is redundant. Removed one of these.
  2. when calling app.listen() on the express app, the arrow function that prints a message to log should actually be a second parameter to the listen function. The parentheses are currently closed too early (after the PORT parameter), causing no message to be output to the console as intended.
  3. parseInt function on the PORT is invoked in different patterns in js and ts examples (when extracting env variable in ts, and when invoking app.listen in js). I aligned them so the call is done in the same place for both examples

@blumamir blumamir requested review from a team as code owners November 21, 2022 07:26
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@svrnm svrnm merged commit b772e5b into open-telemetry:main Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants