Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCP function instructions #2091

Merged
merged 26 commits into from
Jan 16, 2023
Merged

GCP function instructions #2091

merged 26 commits into from
Jan 16, 2023

Conversation

klempinen
Copy link
Contributor

@klempinen klempinen commented Dec 12, 2022 •
edited by svrnm

@klempinen klempinen requested review from a team as code owners December 12, 2022 08:24
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 12, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

svrnm
svrnm reviewed Dec 12, 2022
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, overall it looks good to me (although I don't know that much about GCP). I added some comments.

content/en/docs/instrumentation/js/serverless.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/js/serverless.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/js/serverless.md Outdated Show resolved Hide resolved
klempinen and others added 2 commits December 13, 2022 09:08
@klempinen @svrnm
Update content/en/docs/instrumentation/js/serverless.md
bcd0d45 
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
@klempinen @svrnm
Update content/en/docs/instrumentation/js/serverless.md
f12fa63 
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
svrnm
svrnm requested changes Dec 14, 2022
View reviewed changes
content/en/docs/instrumentation/js/serverless.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/js/serverless.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/js/serverless.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/js/serverless.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/js/serverless.md Outdated Show resolved Hide resolved
klempinen and others added 5 commits December 15, 2022 17:08
@klempinen @svrnm
Update content/en/docs/instrumentation/js/serverless.md
1e7d31f 
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
@klempinen @svrnm
Update content/en/docs/instrumentation/js/serverless.md
f74c54c 
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
@klempinen @svrnm
Update content/en/docs/instrumentation/js/serverless.md
46c345b 
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
@klempinen @svrnm
Update content/en/docs/instrumentation/js/serverless.md
9340e13 
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
@klempinen @svrnm
Update content/en/docs/instrumentation/js/serverless.md
fa8f7c0 
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
cartermp
cartermp requested changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor formatting suggestions and some questions. Looking pretty good overall though!

content/en/docs/instrumentation/js/serverless.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/js/serverless.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/js/serverless.md Show resolved Hide resolved
content/en/docs/instrumentation/js/serverless.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/js/serverless.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/js/serverless.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/js/serverless.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/js/serverless.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/js/serverless.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/js/serverless.md Outdated Show resolved Hide resolved
klempinen and others added 10 commits December 19, 2022 10:40
@klempinen @cartermp
Update content/en/docs/instrumentation/js/serverless.md
da48fa9 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@klempinen @cartermp
Update content/en/docs/instrumentation/js/serverless.md
c838dfa 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@klempinen @cartermp
Update content/en/docs/instrumentation/js/serverless.md
2bc1323 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@klempinen @cartermp
Update content/en/docs/instrumentation/js/serverless.md
bcd942c 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@klempinen @cartermp
Update content/en/docs/instrumentation/js/serverless.md
4daee68 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@klempinen @cartermp
Update content/en/docs/instrumentation/js/serverless.md
c6b8efd 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@klempinen @cartermp
Update content/en/docs/instrumentation/js/serverless.md
53234b6 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@klempinen @cartermp
Update content/en/docs/instrumentation/js/serverless.md
f3583f1 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@klempinen @cartermp
Update content/en/docs/instrumentation/js/serverless.md
4408686 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@klempinen @cartermp
Update content/en/docs/instrumentation/js/serverless.md
334e2e4 
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
@svrnm svrnm mentioned this pull request Dec 19, 2022
Open
@klempinen klempinen requested review from cartermp and svrnm and removed request for cartermp January 9, 2023 15:05
@klempinen klempinen requested a review from svrnm January 11, 2023 09:23
@svrnm
Copy link
Member

svrnm commented Jan 11, 2023

I just went through that flow and could setup a function successfully 👍

I added a few more suggestions to improve the flow & readability.

klempinen and others added 4 commits January 11, 2023 12:55
@klempinen @svrnm
Update content/en/docs/instrumentation/js/serverless.md
c157b8f 
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
@klempinen @svrnm
Update content/en/docs/instrumentation/js/serverless.md
b8e41c3 
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
@klempinen @svrnm
Update content/en/docs/instrumentation/js/serverless.md
ff739fd 
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
@klempinen @svrnm
Update content/en/docs/instrumentation/js/serverless.md
0bbbd3b 
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
svrnm
svrnm approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me now

@svrnm svrnm merged commit ec6d3bd into open-telemetry:main Jan 16, 2023
@nicholaschoi168 nicholaschoi168 mentioned this pull request May 19, 2024
Open
@snyk-io snyk-io bot mentioned this pull request May 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svrnm svrnm svrnm approved these changes

@cartermp cartermp cartermp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@klempinen @svrnm @cartermp