Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update php documentation for beta release #2097

Merged
merged 6 commits into from
Dec 14, 2022
Merged

Update php documentation for beta release #2097

merged 6 commits into from
Dec 14, 2022

Conversation

brettmc
Copy link
Contributor

@brettmc brettmc commented Dec 13, 2022

  • update PHP stability to beta for trace + metrics
  • update existing getting-started documentation
  • add manual and auto instrumentation documentation

@brettmc brettmc requested review from a team as code owners December 13, 2022 00:15
@brettmc brettmc force-pushed the update-php-documentation branch 6 times, most recently from 2b746b7 to cc375ff Compare December 13, 2022 10:46
svrnm
svrnm requested changes Dec 13, 2022
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🎉

content/en/docs/instrumentation/php/automatic.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/php/automatic.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/php/automatic.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/php/automatic.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/php/automatic.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/php/manual.md Outdated Show resolved Hide resolved
brettmc and others added 2 commits December 14, 2022 09:29
@brettmc @svrnm
Apply suggestions from code review
f0ddae4 
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
@brettmc
apply code review suggestion
40a1e0d
svrnm
svrnm approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@svrnm svrnm merged commit 990d5c1 into open-telemetry:main Dec 14, 2022
@brettmc brettmc deleted the update-php-documentation branch June 21, 2023 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svrnm svrnm svrnm approved these changes

@bobstrecansky bobstrecansky bobstrecansky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brettmc @svrnm @bobstrecansky