Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mastodon link to footer #2115

Merged
merged 3 commits into from
Dec 19, 2022
Merged

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Dec 19, 2022

Related: #2104

the best place for having the link to the mastodon account would be the footer where we have all those other links.

Only challenge: I can not set the rel="me" easily, this is something that probably needs to be fixed in docs, @chalin?

Signed-off-by: svrnm <neumanns@cisco.com>
@chalin
Copy link
Contributor

chalin commented Dec 19, 2022

the best place for having the link to the mastodon account would be the footer where we have all those other links.

Agreed.

Only challenge: I can not set the rel="me" easily, this is something that probably needs to be fixed in docs, @chalin?

Yes, I can work on that.

config.yaml Outdated Show resolved Hide resolved
@chalin
Copy link
Contributor

chalin commented Dec 19, 2022

I think that there's value in adding the Mastodon link to the footer -- without removing Twitter, and without removing the "verification" link from it's current place. If you'd like @svrnm, I'll deal with #2104 (probably in two steps: first relocating it, then making the enhancement to the Docsy template). WDYT?

Signed-off-by: svrnm <neumanns@cisco.com>
Signed-off-by: svrnm <neumanns@cisco.com>
@svrnm
Copy link
Member Author

svrnm commented Dec 19, 2022

I think that there's value in adding the Mastodon link to the footer -- without removing Twitter, and without removing the "verification" link from it's current place. If you'd like @svrnm, I'll deal with #2104 (probably in two steps: first relocating it, then making the enhancement to the Docsy template). WDYT?

Let's do it that way. Having it as part of the docsy template will then also help other projects to have their mastodon handles verified.

@svrnm svrnm marked this pull request as ready for review December 19, 2022 14:23
@svrnm svrnm requested a review from a team as a code owner December 19, 2022 14:23
@svrnm svrnm changed the title Move Mastodon link to footer Add Mastodon link to footer Dec 19, 2022
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants