Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typos and consistency #2135

Merged
merged 1 commit into from
Dec 29, 2022
Merged

fix typos and consistency #2135

merged 1 commit into from
Dec 29, 2022

Conversation

windsonsea
Copy link
Member

@windsonsea windsonsea commented Dec 29, 2022 •
edited

  • Fix some minor typos
  • Fix a consistency about Ctrl + C, which have more hits than Control+C though it's not wrong:

image

@windsonsea windsonsea requested review from a team as code owners December 29, 2022 04:06
@windsonsea windsonsea requested review from codeboten and removed request for a team December 29, 2022 04:06
svrnm
svrnm approved these changes Dec 29, 2022
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for your continuous efforts :)

@cartermp cartermp merged commit 53623f7 into open-telemetry:main Dec 29, 2022
@windsonsea windsonsea deleted the ctrlc branch January 9, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svrnm svrnm svrnm approved these changes

@codeboten codeboten Awaiting requested review from codeboten codeboten is a code owner automatically assigned from open-telemetry/collector-approvers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@windsonsea @svrnm @cartermp