add examples for async counter, updown counter, gauge #2144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
4 tasks
svrnm
reviewed
Jan 9, 2023
pichlermarc
reviewed
Jan 9, 2023
Co-authored-by: Marc Pichler <marcpi@edu.aau.at>
Co-authored-by: Marc Pichler <marcpi@edu.aau.at>
|
@svrnm @pichlermarc just address your comments on this PR, and also added a section on views as per the issue #2052 |
cartermp
reviewed
Jan 9, 2023
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
|
@cartermp thanks for all the suggestions - just addressed the last two comments on this PR in my latest commit |
cartermp
approved these changes
Jan 11, 2023
pichlermarc
approved these changes
Jan 12, 2023
Co-authored-by: Marc Pichler <marcpi@edu.aau.at>
Co-authored-by: Marc Pichler <marcpi@edu.aau.at>
|
@pichlermarc thanks for the suggestions! i committed them as well - i think they really tie all the examples together for the views :) |
chalin
reviewed
Jan 12, 2023
There was a problem hiding this comment.
@svrnm et al., see inline for a question.
@Omkar-Waingankar, thanks for your PR! One nit: please line-wrap paragraphs to 80 chars.
chalin
reviewed
Jan 12, 2023
chalin
reviewed
Jan 12, 2023
chalin
reviewed
Jan 12, 2023
chalin
reviewed
Jan 12, 2023
chalin
reviewed
Jan 12, 2023
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
|
@chalin any further suggestions? |
svrnm
approved these changes
Jan 18, 2023
|
will merge this now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
additiveandmonotonicwhich are not necessarily referenced in earlier descriptions. i think we should agree on making all of these consistent before merging.Preview: https://deploy-preview-2144--opentelemetry.netlify.app/docs/instrumentation/js/instrumentation