[PHP] Update and extend setup for auto instrumentation #2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svrnm
requested changes
Jan 10, 2023
pdelewski
force-pushed
the
update-setup-auto-instr
branch
from
9656366
to
ffe176e
Compare
|
thx for fixing the formatting, I think you need to add more tabs/spaces to the code snippets, since they are not in line with their bullet point: https://deploy-preview-2151--opentelemetry.netlify.app/docs/instrumentation/php/automatic/#setup |
ok, thank you |
pdelewski
force-pushed
the
update-setup-auto-instr
branch
from
ffe176e
to
e7b2469
Compare
pdelewski
force-pushed
the
update-setup-auto-instr
branch
from
e7b2469
to
0c1e39f
Compare
svrnm
approved these changes
Jan 10, 2023
cartermp
approved these changes
Jan 10, 2023
|
Merging since you're a maintainer :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.