Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semantic conventions to the concepts TOC in docs #2153

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

cartermp
Copy link
Contributor

Adds it so you can navigate to this very important concept easily.

It should have more commentary and all that, but for now let's surface it more.

@cartermp cartermp requested a review from a team as a code owner January 10, 2023 20:47
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it make the most sense to have such a page under /docs/reference/specification?

@cartermp
Copy link
Contributor Author

I don't think so, no. Eventually this page should have commentary and link out to the reference as needed. I don't want to start adding docs-like things that summarize and rephrase concepts to the spec. Additionally, I think we lose discovery by making it part of the spec. In general I've found a deep reluctance to dive into the spec when talking to end users.

@svrnm svrnm merged commit 9c679cc into open-telemetry:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants