Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php.ini has to be updated manually #2192

Merged
merged 1 commit into from
Jan 24, 2023
Merged

php.ini has to be updated manually #2192

merged 1 commit into from
Jan 24, 2023

Conversation

pdelewski
Copy link
Member

Installing extension via pickle requires updating php.ini

@pdelewski pdelewski requested review from a team as code owners January 24, 2023 11:49
@chalin
Copy link
Contributor

chalin commented Jan 24, 2023

Preview: https://deploy-preview-2192--opentelemetry.netlify.app/docs/instrumentation/php/automatic/#setup

chalin
chalin reviewed Jan 24, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments for suggested copyedits and a fixed code-block language. This is what the result looks like once included in the PR:

image

Also: Prettier should be run over this file.

content/en/docs/instrumentation/php/automatic.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/php/automatic.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/php/automatic.md Outdated Show resolved Hide resolved
@chalin
php.ini has to be updated manually
cc321da 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
cartermp
cartermp approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving + merging as this is sourced from a maintainer!

@cartermp cartermp merged commit 23d6adc into open-telemetry:main Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svrnm svrnm svrnm approved these changes

@chalin chalin chalin approved these changes

@cartermp cartermp cartermp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pdelewski @chalin @svrnm @cartermp