Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Add doc for disabling instrumentation for python #2196

Merged

Conversation

TylerHelmuth
Copy link
Member

Adds docs to Python's auto-instrumentation config and the k8s operator auto-instrumentaiton config for python explaining how to omit specific packages from instrumentation. This is an important feature in auto-instrumentation as instrumenting everything can lead to too much data or noise.

@TylerHelmuth
Copy link
Member Author

Prettifying resulted in a lot of extraneous changes. Opened #2197 to address them separately.

@cartermp
Copy link
Contributor

@open-telemetry/operator-approvers and @open-telemetry/python-approvers please take a look!

@TylerHelmuth
Copy link
Member Author

/cc @srikanthccv @pavolloffay

@srikanthccv
Copy link
Member

On a separate note, there are many other (undocumented) config options Python auto instrumentation supports. It will be good to document them under the Agent Config section.

@cartermp
Copy link
Contributor

cartermp commented Jan 27, 2023

@srikanthccv yes, agreed! Is there a good list to look at somewhere, even if it's just in code somewhere? I'll want to at least get that put into an issue.

@srikanthccv
Copy link
Member

Something I could think of immediately

I'll want to at least get that put into an issue.

Please do. There are probably more options buried inside the code base. I will add more to issue as I dig more.

@cartermp
Copy link
Contributor

Thanks, filed #2214

Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@svrnm svrnm merged commit d697d11 into open-telemetry:main Jan 30, 2023
@TylerHelmuth TylerHelmuth deleted the python-instrumentation-disable branch January 30, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants