Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address accessibility issues of Mastodon rel=me link #2206

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Address accessibility issues of Mastodon rel=me link #2206

merged 1 commit into from
Jan 27, 2023

Conversation

Arhell
Copy link
Member

@Arhell Arhell commented Jan 26, 2023

resolve #2199

@Arhell Arhell requested a review from a team as a code owner January 26, 2023 02:35
chalin
chalin requested changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned in the issue, this link isn't visible and so this addition is unnecessary.

chalin
chalin approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, we do need to deal with tabbing too. Thanks!

Now that I've had a bit of time to look into this more, I see that further changes are needed. I'll deal with them while working on #2104.

@chalin chalin changed the title Accessibility add link name Address accessibility issues of Mastodon rel=me link Jan 27, 2023
@chalin chalin merged commit ce127ea into open-telemetry:main Jan 27, 2023
@Arhell Arhell deleted the link branch January 27, 2023 14:11
@chalin chalin mentioned this pull request Jan 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accessibility issues with Mastodon rel=me link
2 participants
@Arhell @chalin