-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenTelemetry PHP Beta Blog Post #2219
OpenTelemetry PHP Beta Blog Post #2219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay, the PR builds!
From #2200 (review):
Rename:
- From
content/en/blog/2023/opentelemetry-php-beta-release/index.md
- To
content/en/blog/2023/php-beta-release.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm, @cartermp can you give this a once-over as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much sparking of joy to be had. Will follow up with a banner update for this when it's posted.
57ecc20
to
671a655
Compare
Sorry for the force push - had to change my local .git config on a different machine than I normally commit from. |
@chalin - I think this is fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✨
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@chalin - feel free to merge this at will. |
🎉 |
Creating an OpenTelemetry PHP Beta Announcement Blog Post