Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry PHP Beta Blog Post #2219

Merged
merged 3 commits into from
Jan 30, 2023

Conversation

bobstrecansky
Copy link
Contributor

Creating an OpenTelemetry PHP Beta Announcement Blog Post

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, the PR builds!

From #2200 (review):

Rename:

  • From content/en/blog/2023/opentelemetry-php-beta-release/index.md
  • To content/en/blog/2023/php-beta-release.md

Copy link
Member

@austinlparker austinlparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm, @cartermp can you give this a once-over as well?

Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much sparking of joy to be had. Will follow up with a banner update for this when it's posted.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 30, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@bobstrecansky
Copy link
Contributor Author

Sorry for the force push - had to change my local .git config on a different machine than I normally commit from.

@svrnm svrnm requested a review from chalin January 30, 2023 14:52
@bobstrecansky
Copy link
Contributor Author

@chalin - I think this is fixed now.

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

content/en/blog/2023/php-beta-release.md Outdated Show resolved Hide resolved
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@bobstrecansky
Copy link
Contributor Author

@chalin - feel free to merge this at will.

@svrnm svrnm merged commit 60316e6 into open-telemetry:main Jan 30, 2023
@svrnm
Copy link
Member

svrnm commented Jan 30, 2023

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants