Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTel in Focus Jan 2023 #2237

Merged
merged 9 commits into from
Feb 1, 2023
Merged

OTel in Focus Jan 2023 #2237

merged 9 commits into from
Feb 1, 2023

Conversation

cartermp
Copy link
Contributor

@cartermp cartermp commented Jan 31, 2023 •
edited by chalin

@cartermp cartermp requested review from a team as code owners January 31, 2023 16:16
@austinlparker
Copy link
Member

Thanks! We won't have to do this next time since y'all can approve now...

cartermp and others added 8 commits February 1, 2023 00:20
@cartermp
ghostwrite austin's otel in focus post
cb8900b
@cartermp @austinlparker
Update content/en/blog/2023/opentelemetry-in-focus-january-2023.md
a7205cc 
Co-authored-by: Austin Parker <austin@ap2.io>
@cartermp
yerp
d3a0c23
@cartermp @chalin
Apply suggestions from code review
81d94dc 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@cartermp
Update opentelemetry-in-focus-january-2023.md
71d590b
@cartermp @chalin
Update content/en/blog/2023/opentelemetry-in-focus-january-2023.md
1357b1e 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@cartermp @chalin
Update content/en/blog/2023/opentelemetry-in-focus-january-2023.md
f24242e 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@cartermp
rename
4adeeab
chalin
chalin approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

See inline for a few final teaks (e.g., added link to Slack channel).

content/en/blog/2023/otel-in-focus-01.md Outdated Show resolved Hide resolved
content/en/blog/2023/otel-in-focus-01.md Outdated Show resolved Hide resolved
content/en/blog/2023/otel-in-focus-01.md Outdated Show resolved Hide resolved
@chalin chalin mentioned this pull request Feb 1, 2023
Closed
@cartermp @chalin
Apply suggestions from code review
1dde512 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@cartermp cartermp merged commit a6dee6e into open-telemetry:main Feb 1, 2023
@cartermp cartermp deleted the cartermp/otel-in-focus-1 branch February 1, 2023 00:50
@jewel0405 jewel0405 mentioned this pull request Aug 27, 2023
Open
@jewel0405 jewel0405 mentioned this pull request Feb 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

@austinlparker austinlparker austinlparker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cartermp @austinlparker @chalin