Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Collector] Add scaling collector doc #2268

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

TylerHelmuth
Copy link
Member

Adds a new page to the collector documentation on how to scale the collector.

This content was originally written by @jpkrohling and published here: https://grafana.com/docs/opentelemetry/collector/how-to-scale/. I was given permission to reuse that content for the OpenTelemetry docs.

The content has been largely untouched; only very slight grammatical touch-ups have been made.

Thank you so much @jpkrohling for writing this article and donating it to the project!

@TylerHelmuth TylerHelmuth requested review from a team as code owners February 3, 2023 19:29
@TylerHelmuth TylerHelmuth requested review from mx-psi and removed request for a team February 3, 2023 19:29
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

content/en/docs/collector/scaling.md Show resolved Hide resolved
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't read it fully (again), but looks good to me. Someone in the community mentioned that they'd benefit from having images demonstrating the concepts. Perhaps this could be a "help wanted" issue for someone else to work on.

The sidecar pattern consists in adding a container into the workload pod. The
[OpenTelemetry Operator](/docs/k8s-operator/) can automatically add that for
you. To accomplish that, you’ll need an OpenTelemetry Collector CR and you’ll
need to annotate your PodSpec or Pod telling the operator to inject a sidecar:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just confirming: the original post has backticks around terms like PodSpec and Pod -- did you intentionally remove them?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the copy and paste didn't keep them since I took from the website. I tried to replace everything but I probably missed some. I'll do another proofread and add back any formatting I missed.

Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Joy-sparking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants