Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add otel4s to registry #2295

Merged
merged 4 commits into from
Feb 7, 2023
Merged

Add otel4s to registry #2295

merged 4 commits into from
Feb 7, 2023

Conversation

rossabaker
Copy link
Contributor

No description provided.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 7, 2023 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: rossabaker / name: Ross A. Baker (65b2050)

@rossabaker
Copy link
Contributor Author

Drafted so @iRevive and @zmccoy can confirm spelling variants and whether they want their e-mails listed. Sorted alphabetically, though Maksym deserves to be at the top. 😆

@iRevive
Copy link

iRevive commented Feb 7, 2023

Thanks! You can add my email: maxochenashko@gmail.com

@zmccoy
Copy link

zmccoy commented Feb 7, 2023

Thank you. You can add my email: zachabbott@gmail.com

chalin
chalin reviewed Feb 7, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that this is still in draft, but in case I can't get back to this before it's approved and merged: ... drop the YAML comment

data/registry/otel-scala.yml Outdated Show resolved Hide resolved
@rossabaker @chalin
Drop the YAML comment
8732de3 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@rossabaker rossabaker marked this pull request as ready for review February 7, 2023 21:26
@rossabaker rossabaker requested a review from a team as a code owner February 7, 2023 21:26
cartermp
cartermp approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cartermp cartermp merged commit 4b3b712 into open-telemetry:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin left review comments

@cartermp cartermp cartermp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rossabaker @iRevive @zmccoy @chalin @cartermp